Skip to content

ncmpcpp: update to 0.10.1#54659

Closed
MatiasConTilde wants to merge 1 commit into
void-linux:masterfrom
MatiasConTilde:master
Closed

ncmpcpp: update to 0.10.1#54659
MatiasConTilde wants to merge 1 commit into
void-linux:masterfrom
MatiasConTilde:master

Conversation

@MatiasConTilde
Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • armv6l

@slymattz
Copy link
Copy Markdown
Contributor

slymattz commented Mar 12, 2025

Hi @MatiasConTilde

I just want to let you know that there's a PR that has a competing commit. As far as I understand, the Void policy on stable releases vs GH tags favors the former. Moreover, https://rybczak.net/ncmpcpp/installation/ speaks of the stable vs development versions and the stable release still links to 0.9.2, so I'm not sure what the maintainer would say here. I think it's a good idea to ping the maintainer directly and see what they've go to say. Maybe it's time to move on with the version, maybe not :D

@MatiasConTilde
Copy link
Copy Markdown
Contributor Author

Hi thanks for your input, I didn't know about the policy or the other commit.
What I thought is that because ncmpcpp has had very slow developement in the recent years, the website was forgotten to update and that's why it links to an older version. Both 0.9.2 and 0.10.1 have the same major version so I think they are in the same stage, and there also exists the version 0.10_dev (ncmpcpp/ncmpcpp@5dfbd3f) which suggests that a development version would have a different name.
Regarding the competing commit, compatibility with taglib 2.0 is already patched upstream (ncmpcpp/ncmpcpp@dc46f7a) so I believe it would not be necessary anymore, right?
But yes maybe we can ping @arybczak to see what he thinks.

@slymattz
Copy link
Copy Markdown
Contributor

Hi @MatiasConTilde thanks for your input. By pinging maintainer I meant @cinerea0. But hearing from the author of this program might also shed some light on which of the releases should be considered stable. I have no problem dropping my commit and resolving a base conflict in my PR should it arise - just so you know :)

@arybczak
Copy link
Copy Markdown

arybczak commented Mar 13, 2025

Info at rybczak.net is outdated (I really need to remove this page and redirect to GitHub), 0.10.1 is the latest stable.

@slymattz
Copy link
Copy Markdown
Contributor

slymattz commented Mar 20, 2025

@MatiasConTilde I took the liberty of taking your commit to my bulky taglib2 PR. I hope you don't mind. Whichever gets merged sooner, if at all, shouldn't matter and I had to rebuild ncmpcpp anyway for shlib revbump purposes. Cheers!

@slymattz slymattz mentioned this pull request May 19, 2025
33 tasks
@classabbyamp
Copy link
Copy Markdown
Member

#54493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants